source: branches/checkpointing/gj/doc/fixes.txt @ 3280

BUG/[id/5]

BUG/00001: Tools.isRemote(Symbol sym, Symtab syms) cause assertion
  failure "is interface"
FIX: assertion weakened (now allowed to check interfaces, too)
STATE: fixed.

BUG/00002: Symtab.serializableType
  was declared to be "java.lang.Serializable"
FIX: changed to "java.io.Serializable"
STATE: fixed.

BUG/00003: TransBody._case(MethodDef t, Context c)
  several 'NullPointerExceptions' while transforming code because of
  missing optional Tree subnodes
FIX: before recursing test sub node for '!= null'
STATE: fixed.

BUG/00004: TransCopy._case(Literal that, Factory f)
  a literal was created with the Tree.tag instead of the
  Literal.typetag. This caused the string literal to loos their double
  quotes while pretty printing them.
FIX: use the constants TypeTags
STATE: fixed.

BUG/00005: TransCopy
  did not produce an fully attributed copy (types where missing)
FIX: node types are now copied, too.
STATE: fixed.

BUG/00006: TransBody
  did recurse into uninteresting parts like type
  identifiers. Identifiers are assumed to be identifiers for
  variables. 
FIX: overriding additionally _cases methods to limit
  the recursion to interesting parts.
STATE: fixed.

BUG/00007: Wrong source code positions after transformation. The
  attribution phase relies on correct ordering of source code
  positions (Tree.pos). After transformation some of these positions
  are set to zero, which leads to the error message "illegal forward
  reference".
FIX: The tree is cleaned after transformation from old symbol
  references and *all* positions are reset to zero.

BUG/00008: dublicated semicolon in var get/set/inc implementation methods
  return n;;
FIX: no semicolor after expansion of @body@
STATE: fixed.

BUG/00009: missing blank line for separating methods
FIX: newLine() added to TransformCode, call to newLine() added after each 
  generation of method and declaration
STATE: fixed.

BUG/00010: poor indentation
FIX: added indent() and unindent() methods to TransformCode, indenting
  all methods and definition inside classes Use the indentation
  facility of the pretty printer for code, which is inserted in the
  SourceGenerator
STATE: todo.
 
BUG/00011: output of generated code should be placed in the output
  directory.
STATE: todo.

BUG/00012: needs full package name for package declaration
FIX: 'cd.sym.owner.fullName()' instead of 'cd.sym.owner' in definition
  for @package@
STATE: fixed.

BUG/00013: no remote modifiers in transformed classes
FIX: remove REMOTE modifier in @handleclassmods@ by setting it to
  'cd.flags & ~REMOTE'
STATE: fixed.

BUG/00014: crazy static set/get methods for arrays public
  examples.first.Simple[] static Simple[] objs = new Simple[10]_get_()
  throws java.rmi.RemoteException;
FIX: 'vd.name" instead of 'vd' in definition for @var@
STATE: fixed.

BUG/00015: missing opening '{' of static get/set/inc handle methods
FIX: "{" appended in generation of handle for static method
STATE: fixed.

BUG/00016: missing closing '}' of static get/set/inc handle methods
FIX: "}" appended in generation of handle for static method
STATE: fixed.

BUG/00017: dimension parameters for partial array access in
  get/set methods missing
PROBLEM: dimension parameter was 0 for access of dimension 1, 
  so no parameters and arguments were generated
FIX: starting with dimension 1 for generating partial array access
STATE: fixed.

BUG/00018: missing semicolon in instance implementation after
  variable declaration
FIX: ';' added after expandion of @vardef@ in instance implementation 
STATE: fixed.

BUG/00019: in general, full classname needed for 'extends xxx' 
FIX: all @superXXX@ are now set to their 'fullName()'
STATE: fixed.

BUG/00020: spelling mistake: java.rmi.RemoteExeption
FIX.
STATE: fixed.

BUG/00021: Transformation error, _handleToXXX(XXX_class _x)
  expects a class interface, is invoked with the instance
  implementation (implementing the instance interface). The original
  transformation generates a method, which expects an object of type
  XXX_intf.

  public static Simple _handleToSimple(Simple_class _x) {
    return new Simple(_x);
  }

  public synchronized void _init()
    throws java.rmi.RemoteException
  {
    __init();
    _this = XXX._handleToXXX(this);
  }
FIX: transformation adjusted:
  in TransRemote.generateAdditionals() changed
     public static @handle@ _handleTo@handle@(@classIntf@ _x)
  to
     public static @handle@ _handleTo@handle@(@instanceIntf@ _x)
STATE: fixed.

BUG/00022: increment access on remote arrays: order of index arguments is
reversed
FIX: changed the order of arguments created in  
  TransBody.VarAccess.getIndexArguments(List<Tree> args)
STATE: fixed.

BUG/00023: missing pre/post increment argument in the increment method
declaration. Only pre-increment semantics possible.
FIX: transformation in
  TransRemote.generateInstanceIncMethod(RemoteClassBundle gen,
  SourceGenerator.Scope _s)
  TransRemote.generateStaticIncMethod(RemoteClassBundle gen,
  SourceGenerator.Scope _s) changed.  
STATE: fixed.

BUG/00024: missing import declarations: The transformed method
  bodies and signatures may reference types, which are imported
  through an import declaration. These type references are not
  adjusted to fully qualified names by the transformation. To produce
  a valid source code representation of the transformed code all
  necessary import declarations must be added.  
FIX-1: All type references in the scope of the transformed class, which
  are unique in this scope, are imported explicitly with a separate
  import statement.
FIX-2: FIX-1 results in many superflous import declarations, some of
  them referencing non-public inner classes, which crashes the next
  attribution phase. The old import declarations are now collected in
  another tree traversal and prepended to the transformaed class.
STATE: fixed.

BUG/00025: TransBody.VarAccess.makeIncAccess(int opcode, Factory
  f) used arrayElemType(var.type) to determine the required type for
  the Literal representing the value, with witch the variable is
  incvremented. This is inadequate, if the variable is casted.  
FIX:
  use arrayElemType(expr.type) 
STATE: fixed.

BUG/00026: type casted array access to objects of type Object in
  remote classes not yet handled. Eg: ((int[]) r.x)[y] 
FIX: preliminary solution for read accesss: access whole array and
  select localy.
TBD: set access results in incorrect code, because the side effect
  occurs localy and is therefore lost. This case might be handled in
  an extended transformation for general access to local subobjects of
  remote objects.  
STATE: fixed.

BUG/00027: Variable access is not transformed within method
  arguments. Tree.doVisit() does not update the elements of the
  visited List.
FIX: replaced by TransRecurse.doVisit()
STATE: fixed.

BUG/00028: names for variable access methods must contain the
  class name to aviod overriding the method in a super class, which
  declares a variable of the same name.  
FIX: method names replaced with @classID@_[set|get|inc]_@varname@,
  @classID@ is the fully qualified classname with '.' replaced by '_'.
STATE: fixed.

BUG/00029: In tests for equality 'null' constants were considered to
  be eventually remote.
FIX: Tools.maybeRemote(Tree) added, whitch tests for 'null'
STATE: fixed.

BUG/00030: 'null' constants were prepended with a package or class
  reference like variables of classes. 'null' is represented internally
  as variable and the class TransBody.VarAccess was not aware of that.
FIX: special handling of 'null' in TransBody.VarAccess 
STATE: fixed.

BUG/00031: no import declarations were generated. The wrong
  'Scope' was used in Tools.prependImports() for figuring out all
  names, which have to be imported.  
FIX: TopLevel.starImportScope and TopLevel.namedImportScope are now
  used.
STATE: fixed.

BUG/00032: '.signature' files were read back as source Java files
  instead of class files.
FIX: ClassReader decides wether to parse a file depending on its
  extension. It was not aware of '.signature' files in
  ClassReader.fillIn(ClassSymbol).
STATE: fixed.

BUG/00033: access to 'this' is not transformed to '_this'. This
  happened if 'this' occurs e.g. as parameter in a method call, witch
  itself occurs in a reference of a method call. The reference of a
  method call was not visited in some circumstances.
FIX: visit the reference of a method call, if the reference is not
  static and not a self reference. See TransBody._case(Apply,
  Context).
STATE: fixed.

BUG/00034: final variables are accessed through methods. This
  causes problems when the variables are used as patterns in switch
  statements.
STATE: todo.

BUG/00035: 'private' and 'protected' variables get private and
  protected access method within the handle class. They are no longer
  accessible from all parts (static and instance) of the remote
  object.
FIX: public access in interface and implementation, package protected
  access in the handle class.
STATE: todo.

BUG/00036: support for inner classes in remote classes. If this is
  not possible, better error output is required. At the moment an
  InternalError is thrown.
STATE: todo.

BUG/00037
  Remote classes are not checked not to extend a local class. They are
  silently not transformed:
    remote class Worker extends java.lang.Thread {...}
STATE: todo.

BUG/00038
  "T.class" is not transformed correctly. In static contexts the
  construct is transformed to "this.class". This causes an error while
  compiling the transformed code.
STATE: todo.

BUG/00039 "KaRMI Stub generation"
  Parameter reordering was wrong, inverse transformation was missing.
STATE: fixed.

BUG/00040
  Member fields of static inner classes are incorrectly reported to hide 
  non-static member fields of the outer class's super class.
FIX: Fix erronous check in Attrib class.
STATE: todo.

BUG/00041 "Java5 support"
  Adjust GJ generics to match those of Java5. This includes support  for 
  bounded and unboundes wildcard type parameters such as <? extends Tree>,
  <? super Tree>, <?>. Additionally there are differences in semantics. Type
  parameters are not accessible from within static contexts, for example.
STATE: todo.

BUG/00042 "Classfile compatibility"
  See BUG/0041: Changes required in the signature parsing methods to support
  wildcard type params. Type params with an interface bound are coded differently.
STATE: todo.