Changeset 2822

Timestamp:

02/22/05 14:48:53 (8 years ago)

Author:

hauma

Message:

Follow-up for [888], resolution to reopened ticket:63.

• Only generate fully qualified accesses, if the accessed variable belongs to an enclosing class. Otherwise generate an access through this.

File:

• trunk/gj/src/gjc/v6/jp/TransBody.java (modified) (3 diffs)

trunk/gj/src/gjc/v6/jp/TransBody.java

@@ -397 +397 @@
                         // Find referenced enclosing type the accessed
                         // variable belongs to. See See: BUG/0063
+                        boolean definedInOuterClass = false;
                         Type vowner = var.owner.type;
                         Type cclazz = c.clazz.type;
                         while (! cclazz.subType(vowner)) {
                             cclazz = cclazz.outer();
+                            definedInOuterClass = true;
                         }
 
@@ -412 +414 @@
                             c.f.at(Position.NOPOS);
                             ref = c.f.Ident(Names._this);
-                        } else if (tools.isFinal(var)) {
-                            // This is another great hack, because
-                            // final variables can not be initialized
-                            // with a fully qualified name, even with
-                            // javac. Is this a bug in javac and gj?
-                            c.f.at(Position.NOPOS);
-                            ref = c.f.Ident(Names._this);
                         } else if (! tools.hasRef(cclazz.tsym)) {
                             // A instance variable of an anonymous
@@ -426 +421 @@
                             ref = null;
                         } else {
-                            c.f.at(Position.NOPOS);
-                            ref = c.f.Select(tools.getRef(cclazz.tsym), Names._this);
+                            if (definedInOuterClass) {
+                                c.f.at(Position.NOPOS);
+                                ref = c.f.Select(tools.getRef(cclazz.tsym), Names._this);
+                            } else {
+                                c.f.at(Position.NOPOS);
+                                ref = c.f.Ident(Names._this);
+                            }
                         }
                         isStaticRef = false;